Skip to content

Conversation

armin-x86
Copy link
Contributor

@armin-x86 armin-x86 commented Oct 4, 2025

Related to: paseo-network/support#145

and also:

Fix: maintain alphabetical ordering of combined Paseo test endpoints

The index.spec.ts test suite enforces that all "Test networks" and "Paseo & parachains" endpoints are alphabetically sorted by their text value.

After adding the Shibuya Testnet (Astar) entry to testParasPaseoCommon, the combined list in testRelayPaseo.linked no longer met that requirement:

  • testParasPaseo (regular parachains) ends with Zeitgeist Battery Station (Z...)
  • testParasPaseoCommon (common chains) begins with Asset Hub (A...)

When these arrays were concatenated, the overall result was not alphabetically sorted, causing the test failure:

AssertionError [ERR_ASSERTION]: Test networks:: Ajuna Network (Paseo) needs to be before Shibuya Testnet (Astar)

To ensure consistent ordering regardless of future additions, the final combined list is now explicitly sorted by text:

linked: [
  ...testParasPaseo,
  ...testParasPaseoCommon
].sort((a, b) => a.text.localeCompare(b.text)),

This guarantees that the global alphabetical check passes and prevents similar regressions if new endpoints are appended later.

Signed-off-by: Armin Teimouri <[email protected]>
Signed-off-by: Armin Teimouri <[email protected]>
Signed-off-by: Armin Teimouri <[email protected]>
@ap211unitech
Copy link
Member

Needs yarn lint & yarn test

@ap211unitech
Copy link
Member

Needs yarn test

@armin-x86
Copy link
Contributor Author

@ap211unitech , yarn lint and test are passed and fixes are applied to the PR.

@ap211unitech ap211unitech merged commit 2ee0a05 into polkadot-js:master Oct 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants